Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add typescript documentation to advanced customization #3355

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

heath-freenome
Copy link
Member

Reasons for making this change

partially fix: #3072

  • Fixed a broken example in custom-templates.md
  • Fixed broken links in the form-props.md
  • Added a new typescript.md file to advanced-customization to document using custom generics
  • Updated mkdocs.yml to replacing Contributing with the new typescript.md file under Advanced Customization, moving Contributing from the bottom to be after Quickstart
    • Also moved all of the Migration Guides into its own subsection
  • Updated the CHANGELOG.md file accordingly

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Screenshots of busted links:

Screen Shot 2023-01-06 at 4 53 48 PM

Screen Shot 2023-01-06 at 4 53 33 PM

partially fix: rjsf-team#3072

- Fixed a broken example in `custom-templates.md`
- Fixed broken links in the `form-props.md`
- Added a new `typescript.md` file to `advanced-customization` to document using custom generics
- Updated `mkdocs.yml` to replacing `Contributing` with the new `typescript.md` file under `Advanced Customization`, moving `Contributing` from the bottom to be after `Quickstart`
  - Also moved all of the `Migration Guides` into its own subsection
- Updated the `CHANGELOG.md` file accordingly
@heath-freenome heath-freenome merged commit 4f8e932 into rjsf-team:main Jan 8, 2023
@heath-freenome heath-freenome deleted the document-typescript branch January 8, 2023 05:49
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this pull request Jun 8, 2023
…m#3355)

partially fix: rjsf-team#3072

- Fixed a broken example in `custom-templates.md`
- Fixed broken links in the `form-props.md`
- Added a new `typescript.md` file to `advanced-customization` to document using custom generics
- Updated `mkdocs.yml` to replacing `Contributing` with the new `typescript.md` file under `Advanced Customization`, moving `Contributing` from the bottom to be after `Quickstart`
  - Also moved all of the `Migration Guides` into its own subsection
- Updated the `CHANGELOG.md` file accordingly
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this pull request Jun 8, 2023
…m#3355)

partially fix: rjsf-team#3072

- Fixed a broken example in `custom-templates.md`
- Fixed broken links in the `form-props.md`
- Added a new `typescript.md` file to `advanced-customization` to document using custom generics
- Updated `mkdocs.yml` to replacing `Contributing` with the new `typescript.md` file under `Advanced Customization`, moving `Contributing` from the bottom to be after `Quickstart`
  - Also moved all of the `Migration Guides` into its own subsection
- Updated the `CHANGELOG.md` file accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Typescript generics support in all themes in the beta
3 participants